Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs_npm with json is not idempotent #39

Open
billyoung opened this issue Sep 17, 2014 · 5 comments
Open

nodejs_npm with json is not idempotent #39

billyoung opened this issue Sep 17, 2014 · 5 comments
Labels
Bug Something isn't working hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Priority: Low Is a nice to have, not an essential

Comments

@billyoung
Copy link

Running into an issue where using the nodejs_npm lwrp with a json (packages.json) file will run 'npm install' on every converge.

nodejs_npm 'node-app-name' do
  path '/path/to/app'
  json true
  user 'bill'
  group 'bill'
  version '1.2.3'
end

it appears that the LWRP only checks the package/version/path of individual node packages, as opposed to the "name" and "version" of the json project being installed and whether or not its dependencies have been satisfied.

@billyoung billyoung changed the title nodejs_npm is not idempotent nodejs_npm with json is not idempotent Sep 17, 2014
@guilhem
Copy link
Contributor

guilhem commented Sep 18, 2014

Hi @billyoung
As I can see on #40 npm list -json format may have changed...
What is you npm version?

@billyoung
Copy link
Author

npm 1.4.23

@guilhem
Copy link
Contributor

guilhem commented Sep 19, 2014

@billyoung can you do a npm install {anything} then a npm list -json in same directory?

@github-actions
Copy link

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

@github-actions github-actions bot added the Stale label Sep 30, 2020
@MarkGibbons MarkGibbons added Needs Triage Issue is waiting to be categorised Priority: Low Is a nice to have, not an essential Bug Something isn't working hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event and removed Stale Needs Triage Issue is waiting to be categorised labels Sep 30, 2020
@MarkGibbons
Copy link
Member

There's some tough issue around idempotence and repeated runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Priority: Low Is a nice to have, not an essential
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants