Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check / confirm that index does downsampling properly #513

Closed
ctb opened this issue Nov 13, 2024 · 1 comment · Fixed by #514
Closed

check / confirm that index does downsampling properly #513

ctb opened this issue Nov 13, 2024 · 1 comment · Fixed by #514

Comments

@ctb
Copy link
Collaborator

ctb commented Nov 13, 2024

I'm not sure #504 fixed downsampling in the index command. This may be a moot point since sourmash-bio/sourmash#3387 should fix this anyway, but might be good to add a test anyway to avoid regressions.
@ctb
Copy link
Collaborator Author

ctb commented Nov 15, 2024

sourmash-bio/sourmash#3397 ensures this, actually. So I think #514 resolves this issue.

@ctb ctb mentioned this issue Nov 15, 2024
Merged
@ctb ctb closed this as completed in #514 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ctb