Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to do manysketch on dayhoff, hp moltypes? #337

Closed
olgabot opened this issue May 19, 2024 · 3 comments · Fixed by #345
Closed

How to do manysketch on dayhoff, hp moltypes? #337

olgabot opened this issue May 19, 2024 · 3 comments · Fixed by #345

Comments

@olgabot
Copy link
Contributor

olgabot commented May 19, 2024

Hello! Hope you are doing well. I would like to try out manysketch for different protein moltypes. I see that the new gather, search, index and check commands all have the option to provide a moltype, but manysketch does not have that option.

For example, if I try putting hp into the --param-string argument, I get the below error:

(sourmash-branchwater)
 Sun 19 May - 12:28  ~/botryllus-data/data/uniprot/2024-05-19 
 @olgabot  sourmash scripts manysketch --debug --singleton --param-string hp,scaled=1,k=24,abund -c 8 --output 2024-05-19__uniprot_sprot.hp.k24.sig.zip manysketch.csv

== This is sourmash version 4.8.8. ==
== Please cite Brown and Irber (2016), doi:10.21105/joss.00027. ==

=> sourmash_plugin_branchwater 0.9.3; cite Irber et al., doi: 10.1101/2022.11.02.514947

params: ['hp,scaled=1,k=24,abund']
sketching all files in 'manysketch.csv' using 8 threads
Loaded 6 rows in total (0 genome and 6 protein files)
Error parsing params string: unknown component 'hp' in params string
Error: Failed to parse params string

Is there a way to make dayhoff and hp sketches with manysketch? Thank you so much!

@ctb
Copy link
Collaborator

ctb commented May 20, 2024

The underlying ability must be there in the Rust code, so it's hopefully just a matter of connecting the dots. But that probably won't be me, at least not this week or next.

@bluegenes
Copy link
Contributor

I can get to this in June when I'm back from my trip :)

@ctb
Copy link
Collaborator

ctb commented Jun 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants