Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow users to adjust labels, etc. in plot_dendrogram function #2915

Closed
ctb opened this issue Jan 13, 2024 · 2 comments · Fixed by #2598
Closed

allow users to adjust labels, etc. in plot_dendrogram function #2915

ctb opened this issue Jan 13, 2024 · 2 comments · Fixed by #2598

Comments

@ctb
Copy link
Contributor

ctb commented Jan 13, 2024

per @LilyAnderssonLee! review

Is it possible to include arguments to allow users to adjust the legends of both matrix and dendrogram plots in the function mentioned in the example: sourmash plot --pdf --lables ecoli_cmp ?
@ctb ctb mentioned this issue Jan 13, 2024
Closed
33 tasks
@ctb
Copy link
Contributor Author

ctb commented Jan 14, 2024

ref #2587, #2452

I think this might be an easy fix, just gotta dig in to what the more recently-added options are here.

@ctb
Copy link
Contributor Author

ctb commented Feb 5, 2024

looks like #2598 is the fix! Now I've gotta make it mergeable :)

@ctb ctb mentioned this issue Feb 5, 2024
Merged
4 tasks
@ctb ctb closed this as completed in #2598 Feb 6, 2024
@ctb ctb closed this as completed in c6831fd Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ctb