Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider importing rust code improvements from sra_search? #2304

Open
ctb opened this issue Oct 3, 2022 · 1 comment
Open

consider importing rust code improvements from sra_search? #2304

ctb opened this issue Oct 3, 2022 · 1 comment
Labels

Comments

@ctb
Copy link
Contributor

ctb commented Oct 3, 2022

in sourmash-bio/sra_search#12, @luizirber defines some functions that seem to me like they would be nice to have in sourmash core -

  • fn check_compatible_downsample - check if two KerMinHash are compatible w/downsampling
  • fn prepare_query - downsample a sketch as needed (a replacement for sig.select_sketch

maybe we should consider bringing them in here?

@ctb ctb added the rust label Oct 3, 2022
@luizirber
Copy link
Member

Note that they were both borrowed from #2230, so technically they will go in at some point. But can also make a smaller PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants