Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maybe create a new set of exceptions for collection loading functions #1417

Open
ctb opened this issue Mar 28, 2021 · 1 comment
Open

maybe create a new set of exceptions for collection loading functions #1417

ctb opened this issue Mar 28, 2021 · 1 comment

Comments

@ctb
Copy link
Contributor

ctb commented Mar 28, 2021

in the refactored database loading code from #1406, we do lots of different kinds of checks - do files exist? are they directories or not? etc. - and all of these checks get subsumed under a ValueError. we should probably create a new set of exceptions that communicate clearly about what is going on. This is especially true if we're going to enable collection loading via plugins #1368 #1353.
@ctb ctb mentioned this issue Mar 28, 2021
Merged
12 tasks
@ctb
Copy link
Contributor Author

ctb commented Jan 8, 2023

In #2428, I added an IndexNotLoaded exception in place of ValueError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb