From e5ea8af3a6734ab1b67a74ae951cd3cc7976b1ff Mon Sep 17 00:00:00 2001
From: "N. Tessa Pierce-Ward" <ntpierce@gmail.com>
Date: Mon, 16 Dec 2024 11:55:51 -0800
Subject: [PATCH] more tests

---
 src/core/src/signature.rs | 87 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 86 insertions(+), 1 deletion(-)

diff --git a/src/core/src/signature.rs b/src/core/src/signature.rs
index 7fdb9b7f2d..f7f3836fc2 100644
--- a/src/core/src/signature.rs
+++ b/src/core/src/signature.rs
@@ -995,7 +995,6 @@ impl TryInto<KmerMinHash> for Signature {
 #[cfg(test)]
 mod test {
 
-    use core::num;
     use std::fs::File;
     use std::io::{BufReader, Read};
     use std::path::PathBuf;
@@ -1441,6 +1440,83 @@ mod test {
         assert_eq!(frame.rc(), b"ACGACT".as_slice());
     }
 
+    #[test]
+    fn test_fw_dna() {
+        let dna_frame = ReadingFrame::DNA {
+            fw: b"ATCG".to_vec(),
+            rc: b"CGAT".to_vec(),
+            len: 4,
+        };
+        assert_eq!(dna_frame.fw(), b"ATCG");
+    }
+
+    #[test]
+    fn test_rc_dna() {
+        let dna_frame = ReadingFrame::DNA {
+            fw: b"ATCG".to_vec(),
+            rc: b"CGAT".to_vec(),
+            len: 4,
+        };
+        assert_eq!(dna_frame.rc(), b"CGAT");
+    }
+
+    #[test]
+    fn test_length_dna() {
+        let dna_frame = ReadingFrame::DNA {
+            fw: b"ATCG".to_vec(),
+            rc: b"CGAT".to_vec(),
+            len: 4,
+        };
+        assert_eq!(dna_frame.length(), 4);
+    }
+
+    #[test]
+    fn test_frame_type_dna() {
+        let dna_frame = ReadingFrame::DNA {
+            fw: b"ATCG".to_vec(),
+            rc: b"CGAT".to_vec(),
+            len: 4,
+        };
+        assert_eq!(dna_frame.frame_type(), "DNA");
+    }
+
+    #[test]
+    fn test_fw_protein() {
+        let protein_frame = ReadingFrame::Protein {
+            fw: b"MVHL".to_vec(),
+            len: 4,
+        };
+        assert_eq!(protein_frame.fw(), b"MVHL");
+    }
+
+    #[test]
+    #[should_panic(expected = "Reverse complement is only available for DNA frames")]
+    fn test_rc_protein_panics() {
+        let protein_frame = ReadingFrame::Protein {
+            fw: b"MVHL".to_vec(),
+            len: 4,
+        };
+        protein_frame.rc();
+    }
+
+    #[test]
+    fn test_length_protein() {
+        let protein_frame = ReadingFrame::Protein {
+            fw: b"MVHL".to_vec(),
+            len: 4,
+        };
+        assert_eq!(protein_frame.length(), 4);
+    }
+
+    #[test]
+    fn test_frame_type_protein() {
+        let protein_frame = ReadingFrame::Protein {
+            fw: b"MVHL".to_vec(),
+            len: 4,
+        };
+        assert_eq!(protein_frame.frame_type(), "Protein");
+    }
+
     #[test]
     fn test_seqtohashes_frames_dna() {
         let sequence = b"AGTCGT";
@@ -1556,6 +1632,15 @@ mod test {
         assert_eq!(frames[5].fw(), b"LDD".as_slice());
     }
 
+    #[test]
+    #[should_panic(expected = "Frame number must be 0, 1, or 2")]
+    fn test_readingframe_translate() {
+        let sequence = b"AGTCGT";
+        let frame_start = 3; // four frames but translate can only
+
+        ReadingFrame::new_translated(sequence, frame_start, false, false);
+    }
+
     #[test]
     #[should_panic(expected = "Skipmer frame number must be < n")]
     fn test_readingframe_skipmer() {