From c7fcad15c9f956f1e6121b37b5c1c2b662c4f46a Mon Sep 17 00:00:00 2001 From: Keegan Carruthers-Smith Date: Tue, 3 Dec 2024 10:35:22 +0200 Subject: [PATCH] gitindex: disable gogit optimization by default We have seen issues on large repos so lets default to off until we fix again. --- gitindex/index.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gitindex/index.go b/gitindex/index.go index 43da5ad5..9db15bc0 100644 --- a/gitindex/index.go +++ b/gitindex/index.go @@ -17,6 +17,7 @@ package gitindex import ( "bytes" + "cmp" "context" "errors" "fmt" @@ -408,9 +409,10 @@ func indexGitRepo(opts Options, config gitIndexConfig) (bool, error) { opts.BuildOptions.RepositoryDescription.Source = opts.RepoDir var repo *git.Repository - // TODO: remove this feature flag once we test this on a large-scale instance. - legacyRepoOpen := os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION") - if b, err := strconv.ParseBool(legacyRepoOpen); b && err == nil { + // TODO: this now defaults to on since we found a bug in it. Once we have + // fixed openRepo default to false. + legacyRepoOpen := cmp.Or(os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION"), "true") + if b, err := strconv.ParseBool(legacyRepoOpen); b || err != nil { repo, err = git.PlainOpen(opts.RepoDir) if err != nil { return false, fmt.Errorf("git.PlainOpen: %w", err)