From 00564e51603c7c0bc25167b072364392706413d6 Mon Sep 17 00:00:00 2001
From: Thomas Eidens <thomas.eidens@embo.org>
Date: Wed, 14 Feb 2024 15:00:04 +0100
Subject: [PATCH] Fixed multiple fetches of docmap data

---
 .../src/components/highlights/list-item.vue   | 43 ++++++++------
 frontend/src/store/by-article-id.js           | 58 +++++++++++++++++++
 frontend/src/store/index.js                   |  2 +
 3 files changed, 84 insertions(+), 19 deletions(-)
 create mode 100644 frontend/src/store/by-article-id.js

diff --git a/frontend/src/components/highlights/list-item.vue b/frontend/src/components/highlights/list-item.vue
index 5d34ffc9..a1f5a700 100644
--- a/frontend/src/components/highlights/list-item.vue
+++ b/frontend/src/components/highlights/list-item.vue
@@ -136,10 +136,9 @@ v-card(v-if="article" color="tertiary")
 
 <script>
 import MarkdownIt from 'markdown-it'
-import { BASE_URL } from '../../lib/http'
 import { serviceId2Name, normalizeServiceName } from '../../store/by-filters'
-import { parseDocmaps, RenderRevTimeline, RenderRevTimelineHorizontal } from '@source-data/render-rev'
-import { mapState, mapGetters } from 'vuex'
+import { RenderRevTimeline, RenderRevTimelineHorizontal } from '@source-data/render-rev'
+import { mapGetters, mapState } from 'vuex'
 import InfoCardsReviewServiceSummaryGraph from '../helpers/review-service-summary-graph.vue'
 
 export default {
@@ -161,8 +160,6 @@ export default {
       dialog: false,
       selectedSource: null,
 
-      // We grab the review from the docmaps, as it's easier to work with it by not relying on the render-rev component
-      maybeReviewSummary: null,
       reviewProcess: null,
       windowWidth: window.innerWidth,
       breakpoint: 800,
@@ -266,6 +263,7 @@ export default {
     },
   },
   computed: {
+    ...mapGetters('byArticleId', ['getReviewProcessForDoi']),
     ...mapGetters('byFilters', ['reviewingService']),
     ...mapState(['snackMessage, snackColor']),
 
@@ -330,32 +328,39 @@ export default {
       let fullLink = "https://twitter.com/intent/tweet?text=" + tweetContent
       return fullLink
     },
+    maybeReviewSummary() {
+      if (!this.reviewProcess) {
+        return null;
+      }
+      let reviewWithSummary = this.reviewProcess.timeline.groups.map(g => g.items).flat().find(i => i.type === "reviews" && i.summaries.length > 0);
+      if (!reviewWithSummary) {
+        return null;
+      }
+      return reviewWithSummary.summaries[0]
+    },
   },
   watch: {
     openPreprintBoxes: function (newVal) {
       this.dataOpenPreprintBoxes = newVal
     },
-  },
-  mounted() {
-    window.addEventListener("resize", () => {
+    windowWidth() {
       const breakpointCrossed = (this.windowWidth < this.breakpoint && window.innerWidth >= this.breakpoint)
         || (this.windowWidth >= this.breakpoint && window.innerWidth < this.breakpoint);
-      this.windowWidth = window.innerWidth;
       if (breakpointCrossed) {
         this.updateReviewTimeline();
       }
+    }
+  },
+  mounted() {
+    window.addEventListener("resize", () => {
+      this.windowWidth = window.innerWidth;
     });
+
     const doi = this.article.doi;
-    fetch(`${BASE_URL}/api/v2/docmap/${doi}`)
-      .then(response => response.json())
-      .then(parseDocmaps)
-      .then(reviewProcess => {
-        let reviewWithSummary = reviewProcess.timeline.groups.map(g => g.items).flat().find(i => i.type === "reviews" && i.summaries.length > 0);
-        if (reviewWithSummary)
-          this.maybeReviewSummary = reviewWithSummary.summaries[0]
-        this.reviewProcess = reviewProcess;
-        this.updateReviewTimeline();
-      });
+    this.$store.dispatch("byArticleId/fetchReviewProcessForDoi", doi).then(() => {
+      this.reviewProcess = this.getReviewProcessForDoi(doi);
+      this.updateReviewTimeline();
+    });
   }
 }
 </script>
diff --git a/frontend/src/store/by-article-id.js b/frontend/src/store/by-article-id.js
new file mode 100644
index 00000000..0d227bc7
--- /dev/null
+++ b/frontend/src/store/by-article-id.js
@@ -0,0 +1,58 @@
+import httpClient from '../lib/http'
+import { BASE_URL } from '../lib/http'
+import { parseDocmaps } from '@source-data/render-rev'
+
+const docmapsApiPath = (doi) => `${BASE_URL}/api/v2/docmap/${doi}`
+
+export const byArticleId = {
+  namespaced: true,
+  state: {
+    reviewProcesses: {},
+  },
+  getters: {
+    getReviewProcessForDoi: (state) => (doi) => {
+      const data = state.reviewProcesses[doi]
+      if (!data) {
+        return undefined
+      }
+      const { reviewProcess } = data
+      return reviewProcess
+    }
+  },
+  mutations: {
+    setReviewProcessForDoi(state, {doi, data}) {
+      state.reviewProcesses[doi] = data
+    },
+  },
+  actions: {
+    async fetchReviewProcessForDoi({ commit, state }, doi) {
+      if (state.reviewProcesses[doi]) {
+        const { promise } = state.reviewProcesses[doi]
+        return promise
+      }
+      // First we get the docmaps
+      const url = docmapsApiPath(doi)
+      const promise = httpClient.get(url)
+        .then((response) => parseDocmaps(response.data))
+        .then((reviewProcess) => {
+          const data = { promise: Promise.resolve(), reviewProcess }
+          commit('setReviewProcessForDoi', {doi, data})
+        })
+        .catch(function (error) {
+          if (error.response.status === 400) {
+            commit("setSnack",
+              { message: "snack.message.error.request", 
+                color: "red" }, 
+              { root: true });
+          } else {
+            commit("setSnack", 
+              { message: "snack.message.error.server", 
+                color: "red" }, 
+              { root: true });
+          }
+        })
+      const data = { promise, reviewProcess: undefined }
+      commit('setReviewProcessForDoi', {doi, data})
+    },
+  },
+}
diff --git a/frontend/src/store/index.js b/frontend/src/store/index.js
index a0116b73..c0a03746 100644
--- a/frontend/src/store/index.js
+++ b/frontend/src/store/index.js
@@ -1,11 +1,13 @@
 import Vue from 'vue'
 import Vuex from 'vuex'
+import { byArticleId } from './by-article-id'
 import { byFilters } from './by-filters'
 
 Vue.use(Vuex)
 
 export default new Vuex.Store({
   modules: {
+    byArticleId,
     byFilters
   },
   state: {