-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update settings menu to make it more in line with iOS settings menu behaviour #111
Comments
I can look into this |
I've updated my local repo and have a new version of the settings page that accomplishes the tasks put out. However, my github desktop is having issues synching with my XCode. |
nevermind I figured it out. I will look into improving the overall look of the page and then hopefully commit the new page tomorrow and we can push it into main for the next version of the app |
Great, thanks for working on this. When you are ready pleas create a pull request. Don't hesitate to reach out if you have any questions. |
@jchudge Who originally suggested this? Can you ask them to clarify what they meant? I can't say I ever needed to "learn a new behaviour" to use it. I also don't recall seeing collapsible sections in the iOS settings app. I agree it could be better organized, but I'm not sure that just adding collapsible headings will be a positive change. In particular "About" might be better placed in the main menu. |
This is John Joseph A. Gatchalian, and I made the proposal. You've already seen my work updating the Weblate translations in English and Spanish, and I also proposed the Auto Unmute feature. What I wanted was that the Settings menu would feel more like IOS Settings. I noticed that the main menu already feels like IOS Settings so maybe it would be a good idea to copy the structure of the main menu into the Settings menu. I didn't intend the new menu to have collapsable headings in the first place. I'm proposing this change because I'm a teacher of assistive technology for blind senior citizens who speak English and Spanish, and I don't want seniors to re-learn a new behavior if they are used to smartphone settings. In order to help veteran Soundscape users not get lost, I want the buttons to keep the original names "General Settings," "Media Controls," "Manage Callouts," "Soundscape Street Preview," "Troubleshooting," "About," and "Telemetry." In the future, "General Settings" may be shortened to "General," "Manage Callouts" may be shortened to "Callouts," and "Soundscape Street Preview" can be shortened to "Street Preview." There's also another proposal that I made to remove the "Audio Beacon" menu from "General Settings" and put it between "Media Controls" and Manage Callouts." Also, we don't want a Troubleshooting button nested inside another Troubleshooting button so it may be necessary to scrap the Troubleshooting heading and use the current button since it is already on the main Settings screen. My new proposal will have 8 buttons rather than a long list of settings on one page. Then when pressing a button, it should open up the appropriate category. Thanks. |
If you don't feel like any of the proposed changes I made are necessary, that's fine also. Originally I proposed and updated the documentation to line up with the new Settings menu, but I made some changes last night so that the documentation doesn't need to line up with the new Settings menu anymore. The latest changes should show up on the Weblate fork anytime. We can scrap this issue and move on, or we can try it out. I don't have to update the documentation any further. |
I will try to complete the changes you requested |
Thanks, and remember that the button names should also be localized. We want to make sure that the English and Spanish speakers can get around in the "Settings" screen. |
@MBtheOtaku and @JJGatchalian I discussed this with @RDMurray briefly yesterday and we agree that for now, keeping things as simple as possible will allow this feature to be completed and pushed into the next build. @JJGatchalian I greatly appreciate your point that the updates you have made to the documentations do not need to relate directly to the Settings menu and there is no dependency between the two of them. |
Hi, so sorry for not seeing this sooner. When you mean revert do you mean revert it back to the version where we did not have any dropdown or expandable sections? |
@MBtheOtaku yes, that's right. Let me know when you might be able to look at this... |
@jchudge @MBtheOtaku I think there's a bit of a misunderstanding. There's nothing to revert since the branch hasn't been merged yet. We can keep the PR open and discuss exactly how the settings reorganization is going to look for a future release. I'm sorry for not pointing this out sooner! |
😌 |
Ok sounds good. I will leave the pull request open. Just as a note my pull request also contains the separate audio beacon section as well. |
Summary of user feedback request
I think it would be a good idea to make the menu behave more like the IOS or Android settings apps. That way beginners don't need to learn a new behavior when looking through the settings. In addition, the new reorganized Settings menu should look less cluttered.
I'd like to see each heading in the Settings menu turned into a button, and then it should open up the group of settings under the current heading.
The text was updated successfully, but these errors were encountered: