Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timekeep fails to build when using android-14.0.0_r50 #837

Open
mlehtima opened this issue Jul 8, 2024 · 2 comments
Open

Timekeep fails to build when using android-14.0.0_r50 #837

mlehtima opened this issue Jul 8, 2024 · 2 comments
Labels

Comments

@mlehtima
Copy link

mlehtima commented Jul 8, 2024

Platform: Android 14
Device: XQ- DQ54
Kernel version: 5,4
Android version: Android 14
Software binaries version:

Previously working on
Build worked with android-14.0.0_r34 but not anymore with android-14.0.0_r50

Description
Build fails with error
vendor/oss/timekeep/Android.mk: error: TimeKeep: Specifies both LOCAL_SDK_VERSION (system_34) and LOCAL_PRIVATE_PLATFORM_APIS (true) but should specify only one

Symptoms
Build fails

How to reproduce
Try to build android-14.0.0_r50 with the health HAL PRs to prevent failure of that part

Additional context
Build uses the health HAL PRs to fix the build of those

@mlehtima mlehtima added the bug label Jul 8, 2024
@MarijnS95
Copy link
Contributor

MarijnS95 commented Jul 8, 2024

Is an Android script setting this for us now? We removed assignment of LOCAL_SDK_VERSION in favour of LOCAL_PRIVATE_PLATFORM_APIS := true a long time ago (in sonyxperiadev/timekeep@9d8bd47).

In any case it's only used to read a vendor prop which seems odd, I'd expect there to be a different way to read this without requiring private platform APIs nowadays? EDIT: Used to be via the "new" sysprop API which I did for opentelephony/ModemConfig but not yet for timekeep: https://github.com/sonyxperiadev/SonyOpenTelephony/pull/3/files. As you can see it switches from private APIs to a specific SDK version.

@MarijnS95
Copy link
Contributor

@mlehtima please try the fix linked above :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants