Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong resolution of big numbers (at the end) when number + currency #170

Open
JohannaSimoens opened this issue May 9, 2019 · 3 comments
Assignees

Comments

@JohannaSimoens
Copy link
Contributor

JohannaSimoens commented May 9, 2019

Parsing Error

Version

0.18.0

Language

en
fr

Parser input

two hundred twenty-three million three hundred one thousand two hundred eleven euros
trois cent deux millions quatre cent trente milles deux cent trente euros

Parser output

+----+-------------+-----------+--------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+
| ix | log(p)      | p         | text                                                                                 | value                                                                                          |
+====+=============+===========+======================================================================================+================================================================================================+
| 0  | -0.11813116 | 0.8885795 | two hundred twenty-three million three hundred one thousand two hundred eleven euros | AmountOfMoney(AmountOfMoneyOutput { value: 223301220.0, precision: Exact, unit: Some("EUR") }) |
+----+-------------+-----------+--------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+

| ix | log(p)     | p          | text                                                                      | value                                                                                          |
+====+============+============+===========================================================================+================================================================================================+
| 0  | -1.9776177 | 0.13839854 | trois cent deux millions quatre cent trente milles deux cent trente euros | AmountOfMoney(AmountOfMoneyOutput { value: 302430240.0, precision: Exact, unit: Some("EUR") }) |
+----+------------+------------+---------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+

Parser expected output (Optional)

+----+-------------+-----------+--------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+
| ix | log(p)      | p         | text                                                                                 | value                                                                                          |
+====+=============+===========+======================================================================================+================================================================================================+
| 0  | -0.11813116 | 0.8885795 | two hundred twenty-three million three hundred one thousand two hundred eleven euros | AmountOfMoney(AmountOfMoneyOutput { value: 223301220.0, precision: Exact, unit: Some("EUR") }) |
+----+-------------+-----------+--------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+
+----+------------+------------+---------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+
| ix | log(p)     | p          | text                                                                      | value                                                                                          |
+====+============+============+===========================================================================+================================================================================================+
| 0  | -1.9776177 | 0.13839854 | trois cent deux millions quatre cent trente milles deux cent trente euros | AmountOfMoney(AmountOfMoneyOutput { value: 302430230.0, precision: Exact, unit: Some("EUR") }) |
+----+------------+------------+---------------------------------------------------------------------------+------------------------------------------------------------------------------------------------+

@rosastern
Copy link
Collaborator

rosastern commented May 9, 2019

@JohannaSimoens thanks for opening the ticket - maybe see if there are useful labels to add (cf. options on the right); also you can assign the issue, to you for example :)

  • I'm pretty sure I've seen the same issue for Spanish but haven't found my note on this yet. It might be that this is a cross-language issue, pertaining to the resolution function used rather than the rule parsing. We need to check.

@rosastern
Copy link
Collaborator

To do: check together with: #125

@rosastern
Copy link
Collaborator

@kali or @hdlj , would be great to investigate this with your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants