Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

until + date (with no starting date) => wrong resolution #166

Open
OdileDevismesSonos opened this issue Mar 28, 2019 · 1 comment
Open
Assignees
Labels
bug fixpending Fix done. Version with fix will be added to ticket.

Comments

@OdileDevismesSonos
Copy link
Collaborator

OdileDevismesSonos commented Mar 28, 2019

until + date => final boundary = date at 00:00:00 => INCORRECT
from + date1 + until + date2 => final boundary = date2 + 1 at 00:00:00 => CORRECT

context:
2019-03-28T10:00:00

Language: en

Parser input

until tomorrow
from yesterday until tomorrow
until the twenty-ninth
from yesterday until the twenty-ninth

Parser output

until tomorrow | TimeInterval(Before(TimeOutput { moment: 2019-03-29T00:00:00+01:00, grain: Day, precision: Exact, latent: false }))

from yesterday until tomorrow | TimeInterval(Between { start: 2019-03-27T00:00:00+01:00, end: 2019-03-30T00:00:00+01:00, precision: Exact, latent: false })

until the twenty-ninth | TimeInterval(Before(TimeOutput { moment: 2019-03-29T00:00:00+01:00, grain: Day, precision: Exact, latent: true }))

from yesterday until the twenty-ninth | TimeInterval(Between { start: 2019-03-27T00:00:00+01:00, end: 2019-03-30T00:00:00+01:00, precision: Exact, latent: false })

Parser expected output (Optional)

@rosastern rosastern added the fixpending Fix done. Version with fix will be added to ticket. label Oct 3, 2019
@rosastern
Copy link
Collaborator

@mayukauenogayer Could you please test these cases in Japanese, if the same semantic couple until/before <datetime> exists, and let us know here if the same issue occurs? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixpending Fix done. Version with fix will be added to ticket.
Projects
None yet
Development

No branches or pull requests

2 participants