Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarking errors due to insufficient permissions for using Criterion #81

Open
vhnatyk opened this issue Feb 21, 2019 · 1 comment · May be fixed by #229
Open

Benchmarking errors due to insufficient permissions for using Criterion #81

vhnatyk opened this issue Feb 21, 2019 · 1 comment · May be fixed by #229

Comments

@vhnatyk
Copy link

vhnatyk commented Feb 21, 2019 •
edited
Loading

Hi again!) Probably minor thing but I'm getting errors due to insufficient permissions when using Criterion on iOS. Would be nice to fix it either with optional parameter or simply by providing sufficient permissions to the Dinghy app. Again - if I will be faster will gladly do PR with fix, but you guys are welcome to overtake 😉

Benchmarking keygen: AnalyzingCriterion.rs ERROR: error: Failed to access file "target/criterion/keygen/new": Operation not permitted (os error 1)
Criterion.rs ERROR: error: Failed to access file "target/criterion/keygen/new/tukey.json": No such file or directory (os error 2)
Criterion.rs ERROR: error: Failed to access file "target/criterion/keygen/new/sample.json": No such file or directory (os error 2)
Criterion.rs ERROR: error: Failed to access file "target/criterion/keygen/new/estimates.json": No such file or directory (os error 2)
@briansmith
Copy link

@vhnatyk The benchmark files are written to $CRITERION_HOME/{crate name}/{bench name}/ where the default of CRITERION_HOME is $CARGO_TARGET_DIR/criterion/. It is likely on iOS that we need to override $CARGO_TARGET_DIR to point to a (temporary) directory into which we can create subdirectories and write files. Ideally:

  • Before running the executable, dinghy would mirror everything (recursively) in $CARGO_TARGET_DIR/critereon to that temporary directory.
  • dinghy would then spawn the executable on that device with $CARGO_TARGET_DIR pointing to that temporary directory
  • dinghy would then mirror the files in the temporary directory back into $CARGO_TARGET_DIR/critereon.

We'd need some way to configure dinghy regarding which files/directories to mirror this way.

@briansmith briansmith mentioned this issue Feb 21, 2024
Open
This was referenced May 7, 2024
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

An attempt at supporting criterion benchmarks simlay/dinghy
2 participants
@briansmith @vhnatyk