Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unknown tags #2

Open
halljson opened this issue Mar 26, 2019 · 2 comments
Open

Add support for unknown tags #2

halljson opened this issue Mar 26, 2019 · 2 comments

Comments

@halljson
Copy link

I needed this code change to get cartridge working:

Screen Shot 2019-03-26 at 7 46 40 PM

Would prefer to merge this into master (rather than forking this repo) so that everyone can use it!

(Tried pushing my branch, but:)

Please make sure you have the correct access rights
and the repository exists.
@tdavis tdavis changed the title EDN Deserialization is broken Add support for unknown tags Mar 27, 2019
@tdavis
Copy link

tdavis commented Mar 27, 2019

Would it be better to offer another arity that let callers set options like :default? What about internal use of read-response-from-disk; is it principally used elsewhere we should consider extending the option?

You can fork the repository and open a PR from your fork. Proposing a patch with an image is... creative.

@halljson
Copy link
Author

you can open a PR from your fork.

TIL! (hence my lazy/creative solution)

Thanks, I'll put in that PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants