Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Youtube Modal 추가, 행사 당일 페이지 수정 #111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: Youtube Modal 추가, 행사 당일 페이지 수정 #111

wants to merge 5 commits into from

Conversation

cos18
Copy link
Contributor

@cos18 cos18 commented May 30, 2020 •
edited
Loading

무엇을 변경했나요?

  • YoutubeModal을 추가했습니다.
  • 랜딩페이지에서 유튜브 모달을 통해 유튜브 라이브 영상이 뜰 수 있도록 추가했습니다.
    • 링크는 유튜브 라이브 페이지가 열리면 수정할 예정입니다.
    • 행사 당일에만 모달이 뜨고, 이후 다시 제거할 예정입니다.
  • 추가적으로, 강연 날짜 오타를 수정했습니다.

Closed #100

@cos18 cos18 added ui:component 디자인 컴포넌트와 관련이 있는 이슈에요! ui:page 특정 페이지와 관련이 있어요! new-feature 새로운 기능..! labels May 30, 2020
@cos18 cos18 requested review from dsa28s and dexterastin May 30, 2020 02:43
@cos18 cos18 self-assigned this May 30, 2020
dsa28s
dsa28s previously approved these changes May 30, 2020
View reviewed changes
@cos18 cos18 requested a review from dsa28s June 1, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexterastin dexterastin Awaiting requested review from dexterastin

@dsa28s dsa28s Awaiting requested review from dsa28s

At least 1 approving review is required to merge this pull request.

Assignees

@cos18 cos18

Labels
new-feature 새로운 기능..! ui:component 디자인 컴포넌트와 관련이 있는 이슈에요! ui:page 특정 페이지와 관련이 있어요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

강연자 신청 STEP01 화면 여백 수정
2 participants
@cos18 @dsa28s