Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering smibhid display drivers happens unintuitively #261

Open
sjefferson99 opened this issue Nov 24, 2024 · 0 comments
Open

Registering smibhid display drivers happens unintuitively #261

sjefferson99 opened this issue Nov 24, 2024 · 0 comments
Assignees
Labels
🔮 enhancement New feature or request ❌ invalid This doesn't seem right 👁 smib-hid SMIBHID related code

Comments

@sjefferson99
Copy link
Member

At present, the display modules needs display to register their drivers in the driver module before they can be access in the display load configured drivers method. This is currently achieved by importing the specific display module and the registration occurs on init. This is not intuitive as your linter tells you about an unused import which totally breaks the display if removed.

Might make more sense to import the specific display module and call the driver registration method. This will clarify what is happening and also appease the linter.

@sjefferson99 sjefferson99 added 🔮 enhancement New feature or request ❌ invalid This doesn't seem right 👁 smib-hid SMIBHID related code labels Nov 24, 2024
@sjefferson99 sjefferson99 self-assigned this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 enhancement New feature or request ❌ invalid This doesn't seem right 👁 smib-hid SMIBHID related code
Projects
None yet
Development

No branches or pull requests

1 participant