-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for absolute titles to be specified in the routesConfig #4
Comments
I understand your example but it would not work like this because if the widgets title should be Your |
That would be the normal default case as it works now taking |
Ok, you're right - I totally missed that. ^^ I also think that an additional optional flag would be the best approach. WDYT about the naming of this flag? const routes = [
{
title: "Welcome to Example Company! The best company around!", // Would be this exactly
titleAsStandalone: true,
component: Homepage,
routes: [
{
title: "Widgets", // NOTE: Title would be "Widgets | Example Company"
path: "/widgets",
component: Widgets,
routes: [
{
title: "Grand Child", // NOTE: Title would be "Grand Child | Widgets | Example Company"
path: "/widgets/:id/grand-child",
component: GrandChild
},
{
title: "Need Help with widgets? | Example Company", // NOTE: Title would be "Need Help with widgets? | Example Company"
path: "/widgets/help",
component: WidgetHelp
}
]
}
]
}
]; |
Your project, so what ever you feel is best. I don't love it as I think out of the context of this conversation it might not immediately be clear. cascadeParentTitles: true,
recurseParentTitles: true,
titleCascade: true,
titleCombineWithParents: true, // Looked at how you describe it in the docs "It combines all titles for the affected routes and sub-routes to one string" In these, it's defaulting to |
The |
It would be nice to be able to state in the config whether the title will be using parent titles and dividers or to specify an absolute title to be used without generation.
An example could be something like this
A solution could
absoluteTitle
withtitle
excludedtitleConcat: 0
meaning don't concat the above N levels (would be nice for the last route example)The text was updated successfully, but these errors were encountered: