Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packerlicious support for packer-builder-arm-image plugin #18

Open
mayn opened this issue Jan 31, 2019 · 3 comments
Open

packerlicious support for packer-builder-arm-image plugin #18

mayn opened this issue Jan 31, 2019 · 3 comments

Comments

@mayn
Copy link

mayn commented Jan 31, 2019

Hi project maintainers!
Members from your community have added partial support for your plugin to packerlicious via mayn/packerlicious#164 .
One of the challenges preventing full support was with undocumented attributes.

If you are interested in expanding packerlicious supports for your plugin.
Please make a pr with the additional attributes.

I could use your help.
Thanks!

@yuval-k
Copy link
Member

yuval-k commented Feb 4, 2019

do you have an example for such pr?
I'm not sure what do you mean exactly.

@mayn
Copy link
Author

mayn commented Feb 6, 2019

hi @yuval-k . here is the properties defined for your plugin https://github.com/mayn/packerlicious/blob/master/src/packerlicious/community/builder.py#L25

Your docs indicate that additional properties are supported, so they would need to be added to that mapping.

@hoshsadiq
Copy link
Contributor

@mayn I'm not a packerlicious user, however, from reading the code, these are all the fields I can see that are possible (note, you want the mapstructure value):

Hope that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants