From 8fdbea94964480d5aae4bd8ad62382adf8e838cd Mon Sep 17 00:00:00 2001 From: Sean Date: Fri, 5 Feb 2021 13:12:37 -0600 Subject: [PATCH] Fix Rubocop violations --- .rubocop.yml | 4 ++++ .../orders_controller_spec.rb | 4 ++-- .../wizard_controller_spec.rb | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index f74dba89..ecfe7207 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -43,6 +43,10 @@ RSpec/VerifiedDoubles: # Sometimes you really need an "anything" double IgnoreSymbolicNames: true +Rspec/Naming/VariableNumber: + # PayPal uses snake_case, we use normal_case ¯\_(ツ)_/¯ + Enabled: false + Style/FrozenStringLiteralComment: Exclude: - spec/**/* diff --git a/spec/requests/solidus_paypal_commerce_platform/orders_controller_spec.rb b/spec/requests/solidus_paypal_commerce_platform/orders_controller_spec.rb index fc32a97a..32b7eab2 100644 --- a/spec/requests/solidus_paypal_commerce_platform/orders_controller_spec.rb +++ b/spec/requests/solidus_paypal_commerce_platform/orders_controller_spec.rb @@ -15,7 +15,7 @@ get solidus_paypal_commerce_platform.verify_total_path, params: params - expect(response).to have_http_status(200) + expect(response).to have_http_status(:ok) end end @@ -29,7 +29,7 @@ get solidus_paypal_commerce_platform.verify_total_path, params: params - expect(response).to have_http_status(400) + expect(response).to have_http_status(:bad_request) end end end diff --git a/spec/requests/solidus_paypal_commerce_platform/wizard_controller_spec.rb b/spec/requests/solidus_paypal_commerce_platform/wizard_controller_spec.rb index 9a934538..68edff4a 100644 --- a/spec/requests/solidus_paypal_commerce_platform/wizard_controller_spec.rb +++ b/spec/requests/solidus_paypal_commerce_platform/wizard_controller_spec.rb @@ -38,7 +38,7 @@ expect(payment_method.preferred_client_id).to eq("CLIENT-ID") expect(payment_method.preferred_client_secret).to eq("CLIENT-SECRET") - expect(response).to have_http_status(201) + expect(response).to have_http_status(:created) end end end