Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Add Form File Upload Section to Router Docs #936

Closed
MatthewIsHere opened this issue Oct 29, 2024 · 0 comments · Fixed by #960
Closed

[Request]: Add Form File Upload Section to Router Docs #936

MatthewIsHere opened this issue Oct 29, 2024 · 0 comments · Fixed by #960
Assignees

Comments

@MatthewIsHere
Copy link

What is this request related to?

Request

📋 Suggested

https://docs.solidjs.com/solid-router/concepts/actions#using-forms-to-submit-data

📋 General description or bullet points

I believe it would be helpful to add a footnote or section that uploading a file requires attribute enctype="multipart/form-data" on the form in order for actions to receive the file. A small section at the bottom of the code example could mention the usage.

I know this is not technically a Solid/Router issue, but I believe it would clear up any errors from new solid-start users. I would be happy to submit a PR, but I wanted to float the idea first.

🖥️ Reproduction of code samples in StackBlitz

No response

@MatthewIsHere MatthewIsHere added the pending review Awaiting review by team members. label Oct 29, 2024
@LadyBluenotes LadyBluenotes removed the pending review Awaiting review by team members. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants