Adds default info to cli arg for --accounts-hash-cache-path #33331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33331 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 793 793
Lines 214828 214828
=========================================
- Hits 176134 176126 -8
- Misses 38694 38702 +8 |
t-nelson
reviewed
Sep 20, 2023
ledger-tool/src/main.rs
Outdated
| @@ -1150,7 +1150,10 @@ fn main() { | |||
| .long("accounts-hash-cache-path") | |||
| .value_name("PATH") | |||
| .takes_value(true) | |||
| .help("Use PATH as accounts hash cache location"); | |||
| .help("Use PATH as accounts hash cache location") | |||
| .long_help( | |||
There was a problem hiding this comment.
why not in .help()? afaik, clap would automatically append a string to .help() for .default()'s value if we could use it in this case.
There was a problem hiding this comment.
Ah, yep, you're right. Regular help does include defaults. I'll make that change.
There was a problem hiding this comment.
Done in 8a81ce0
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
(cherry picked from commit 1d39c31) # Conflicts: # ledger-tool/src/main.rs
brooksprumo
added a commit
that referenced
this pull request
Sep 21, 2023
(cherry picked from commit 1d39c31) # Conflicts: # ledger-tool/src/main.rs
willhickey
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ackport of #33331) (#33336) * Adds default info to cli arg for --accounts-hash-cache-path (#33331) (cherry picked from commit 1d39c31) # Conflicts: # ledger-tool/src/main.rs * resolve merge conflicts --------- Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts hash cache path CLI arg does not inform the user what it's default value is.
Summary of Changes
Add default info.
Note, this PR is simple/minimal on purpose for ease of backporting. I'll do a subsequent PR to better generate the default string using
AccountsDb::DEFAULT_ACCOUNTS_HASH_CACHE_DIR. (See #33117 (comment) for more context.)