RPC node simulate transaction consumed units

[Arrowana]

Problem

The JSON RPC simulate_transaction method does not return a meaningful consumed_units. It returns what is consumed by the successful ixs only. Rather than the total consumed units.

Example:

https://explorer.solana.com/tx/3KMqaFZQwWaL9evSZYWHzptxdqZfS7o1XhQDgLmvPzU1hsAgssnWqQJTWYfXbqBMH4MimSEjLSepQg74aYxe9GN2

Simulating this transaction returned consumed_units 19165

However, it consumed 111,898 units. That value is correct in the transaction meta after submitting as we can see in the explorer

Proposed Solution

@joncinque found it should be an easy fix by adding total_errored_units to accumulated_units

solana/runtime/src/bank.rs

Lines 4359 to 4365 in 2dfcdce

	let units_consumed = timings
	.details
	.per_program_timings
	.iter()
	.fold(0, |acc: u64, (_, program_timing)| {
	acc.saturating_add(program_timing.accumulated_units)
	});

[joncinque]

According to the docs for simulateTransaction at https://docs.solana.com/api/http#simulatetransaction, the unitsConsumed field is "The number of compute budget units consumed during the processing of this transaction", which means that it should probably be reporting all units consumed, even from an errored instruction.

[CriesofCarrots]

Whoa, is that AI spam? I wonder where it got the 545 value.
"each successful instruction manual" is my favorite part.
Okay, I'll shut up now, in case this will encourage it.