-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected response from RPC API getSignaturesForAddress
when until
sig not found
#24620
Comments
@CriesofCarrots what do you think about the proposed solution here? |
I think we may want different handling depending on whether a provided |
This is still an issue, any updates on this? thanks |
This comment was marked as duplicate.
This comment was marked as duplicate.
The proposed fix isn't completely trivial to implement, since we support before/until signatures that don't involve the specified address, and since we check both Blockstore and Bigtable for results. I'd be happy to look a PR for this, though, @jstarry |
Problem
When an RPC node receives a
getSignaturesForAddress
request and cannot find the signature used in theuntil
parameter, it will just return a list of the most recent signatures (up to the limit). This is unexpected in cases where a signature has been confirmed by the cluster but the contacted RPC node has not yet confirmed the signature yet because it is slightly behind. See issue here: #24417Proposed Solution
If
until
cannot be found, return an error responseThe text was updated successfully, but these errors were encountered: