Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify turbine peers on shred receive #20969

Closed
carllin opened this issue Oct 26, 2021 · 2 comments
Closed

Verify turbine peers on shred receive #20969

carllin opened this issue Oct 26, 2021 · 2 comments
Assignees
@jbiseda @behzadnouri
Labels
do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot

Comments

@carllin
Copy link
Contributor

carllin commented Oct 26, 2021

Problem

Under the new shred proposal, it's important we only accept shreds via the correct peers in the turbine path

Proposed Solution

  1. Introduce turbine signatures to shred
  2. Validators sign shreds they retransmit

cc @aeyakovenko
@behzadnouri
Copy link
Contributor

duplicate issue: #28384

@bw-solana
Copy link
Contributor

Adding some more color, #28384 proposes a solution to verify peers based on IP. Pre-requisite for this solution would be QUIC turbine so that IP cannot be spoofed.

Overhead of SigVerify an extra 64B signature per shred would have to be evaluated relative to overhead of QUIC server

@behzadnouri behzadnouri mentioned this issue Jan 13, 2023
Closed
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@behzadnouri behzadnouri added do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbiseda jbiseda

@behzadnouri behzadnouri

Labels
do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot
Projects
Duplicate block prevention and resolution
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbiseda @behzadnouri @carllin @bw-solana