Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OpenTelemetry direct-style tracing interceptor #4103

Open
adamw opened this issue Oct 16, 2024 · 10 comments
Open

Add an OpenTelemetry direct-style tracing interceptor #4103

adamw opened this issue Oct 16, 2024 · 10 comments

Comments

@adamw
Copy link
Member

adamw commented Oct 16, 2024

Introduce a new module, tracing/opentelemetry-tracing-sync, which should include integration with OT's tracing: reading the context from the request and propagating it downstream.

The approach should target "direct-style" (that is, the Identity "effect type"), and be compatible with Loom/Ox, that is with virtual threads & scoped values. Note that the the OT Java libraries often rely on ThreadLocals, which are not Loom-compatible.

The solution should work in conjunction with softwaremill/sttp#2314

@adamw
Copy link
Member Author

adamw commented Oct 16, 2024

/bounty $750

Copy link

algora-pbc bot commented Oct 16, 2024

💎 $1,000 bounty • SoftwareMill

Steps to solve:

  1. Start working: Comment /attempt #4103 with your implementation plan
  2. Submit work: Create a pull request including /claim #4103 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to softwaremill/tapir!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @varshith257 Oct 25, 2024, 2:24:13 PM WIP
🟢 @hoklims Nov 22, 2024, 7:50:22 AM #4180

@adamw
Copy link
Member Author

adamw commented Oct 21, 2024

As we are getting first PRs for the bounties, I've published our "How to prepare a good PR" guide. I should have probably done this right away, sorry! :)

@varshith257
Copy link

varshith257 commented Oct 25, 2024

/attempt #4103

Algora profile Completed bounties Tech Active attempts Options
@varshith257 17 bounties from 9 projects
Scala, Rust,
TypeScript & more
Cancel attempt

@kernel-loophole
Copy link

@adamw is this module is still needed.would love to work on this if anyone is not working .

@varshith257
Copy link

varshith257 commented Nov 16, 2024

@kernel-loophole I had progress on it. Just I have open PR of other issue and I am waiting to merge it and get into this completed

@adamw
Copy link
Member Author

adamw commented Nov 16, 2024

@varshith257 hm which PR you refer to? maybe I've missed something:)

@varshith257
Copy link

varshith257 commented Nov 16, 2024

@adamw #4122

I just made initial changes long before for this issue which I think we primarily need to work on in sttp(softwaremill/sttp#2314 ) and need to test and evaluate my approach. Just thought to complete them (#4057 and https://github.com/softwaremill/sttp/issues/2292one by one rather than solving this set of issues (refactor of OT and this tracing/opentelemetry-tracing-syn issues simultaneously

@hoklims
Copy link

hoklims commented Nov 22, 2024

/attempt #4103

Copy link

algora-pbc bot commented Nov 22, 2024

Note

The user @varshith257 is already attempting to complete issue #4103 and claim the bounty. We recommend checking in on @varshith257's progress, and potentially collaborating, before starting a new solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants