Minimal Expo 52 app crashes when using form sheet modals when using RNTP

[doughsay]

Description

When using react-native-track-player, which uses a Headless JS Task, form sheet modals crash when being opened after the app has been closed once. I haven't been able to reproduce this without using react-native-track-player, but the maintainers there seem to think it's not related to their package. I'm having a hard time knowing where to look for help, and what else to try.

Video showing the crash:

rntp-crash.webm

Steps to reproduce

1. open the app
2. see that the form sheet modal opens
3. close the app (not just background)
4. open the app again
5. try and open the modal and see that it crashes instead

Snack or a link to a repository

https://github.com/doughsay/expo-test-app

Screens version

4.0.0

React Native version

0.76.1

Platforms

Android

JavaScript runtime

Hermes

Workflow

Expo managed workflow

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

Android emulator

Device model

Pixel 9 Pro XL API 35

Acknowledgements

Yes

[doughsay]

Updated to react-native 0.76.2, it didn't help

[doughsay]

Updated to react-native-screen 4.1.0, no change, still crashes. If anyone here thinks this isn't related to anything in react-native-screens, please let me know so I can maybe file an issue somewhere else. It's a bit over my head, and I really need help figuring it out.

[radko93]

Are you using new architecture? headless is broken with new arch facebook/react-native#47570

[doughsay]

Are you using new architecture? headless is broken with new arch facebook/react-native#47570

No, old architecture, although I've tried both with no differences to the crash. But you can see in my repo I have it currently disabled.

[mikehardy]

👋 I'm looking into upstream facebook/react-native/issues/47570 and having trouble reproducing

Right now there is definitely a problem with old-architecture and headlessJS - I have a clean reproducer up and it is tracking in facebook/react-native/issues/47592

I am unable to reproduce failures yet with new architecture and 0.76.1 or .2 but I understand from comments you do reproduce here. I'll see what I can do about converging the two reproducers to something truly minimal (no react-native-track-player needed if possible...) and post it up on 47570

[mikehardy]

I don't believe this is related to headlessJS crashes. I think this is something different now.

[doughsay]

Thanks for chiming in, and I'll follow those two issues just in case they do end up being related. But in this case it doesn't appear to be related to the architecture, I get the same crash either way.

I don't really have the skills in react native to investigate any further on my end, so I'm rewriting my form sheet modals to use gorhom-bottom-sheet instead for now. If this gets resolved in the future I hope I can switch back to using the form sheets provided by react-native-screens.

[kkafar]

Could someone confirm whether applying this patch resolves the issue for you?

https://github.com/software-mansion/react-native-screens/pull/2526.patch

You can either apply this patch or try to install react-native-screens directly from branch:

"react-native-screens": "software-mansion/react-native-screens#@kkafar/fix-crash-with-proxy-already-registered"

The #2526 aims to fix #2519, however it might help here too (in case the issue is caused by this library)

[doughsay]

@kkafar yes, I can confirm that this fixes the crash!

[kkafar]

Thanks for confirmation. I'll release it later today