feat: add compat mode for previously removed formSheet prop values #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging changes to react-navigation to keep things working. I'll update react-navigation to main, once we land these PRs there. |
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…oftware-mansion#2356) ## Description This PR intends to add support for previously removed `sheetAllowedDetents` and `sheetLargestUndimmedDetent` props values: `medium`, `large` and `all`. With addition of custom detents for iOS I've changed the API of NativeScreen component to receive `number[]` as the detent list and removed the old options. This removal was unnecessary. I've restored these options on the `Screen` component abstraction layer, where old options are translated to the new API w/o need for additional support in downstream packages such as react-navigation. Corresponding PR in `react-navigation`: * react-navigation/react-navigation#12032 ## Changes * updated the types, * added "translation layer" in InnerScreen. ## Test code and steps to reproduce Test1649 is great for testing all sheet related props. ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation: <!-- For adding new props to native-stack --> - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to add support for previously removed
sheetAllowedDetentsandsheetLargestUndimmedDetentprops values:medium,largeandall.With addition of custom detents for iOS I've changed the API of NativeScreen component to receive
number[]as the detent list and removed the old options. This removal was unnecessary. I've restored these options on theScreencomponent abstraction layer, where old options are translated to the new API w/o need for additional support in downstream packages such as react-navigation.Corresponding PR in
react-navigation:Changes
Test code and steps to reproduce
Test1649 is great for testing all sheet related props.
Checklist