fix(Windows): Fix issue when emptying nav stack on Windows

[chrisglein]

Description

When using a StackNavigator on an app on Windows, when you popped the stack you would end up with no displayed content instead of the first page.

Changes

The Windows stack implementation wasn't updating Content to the top of the stack (after the removal and motification of the vector).
Also the Windows project had an aggressive assertion of SDK version, causing apps to unnecessarily either download an older SDK or patch their app. See react-native-async-storage/async-storage#810 for a similar fix.

Test code and steps to reproduce

import { NavigationContainer } from '@react-navigation/native';
import { createNativeStackNavigator } from '@react-navigation/native-stack';

// ,,,

const Stack = createNativeStackNavigator();

export default function App() : JSX.Element {
  return (
    <NavigationContainer>
      <Stack.Navigator initialRouteName='Home'>
        <Stack.Screen name='Home' component={HomeScreen} />
        <Stack.Screen name='Details' component={DetailsScreen} />
      </Stack.Navigator>
    </NavigationContainer>
  );
}

Somewhere else

navigation.navigate('Details');

And then later

navigation.goBack();

Result: rendering nothing instead of the 'Home' page.

Yep, that's all it took. As far as I can tell this was broken since implementation, but the usage I know of on Windows was using Drawer and that part's all fine.

Checklist

• Included code example that can be used to test this change
• Updated TS types N/A
• Updated documentation: N/A
• Ensured that CI passes No tests on Windows :'(
• Tested via patch-packing in an app

[tboba]

Hi @chrisglein @jonthysell, thanks for the contribution! 🙏
Have you tested if those changes won't break the current behavior of native stack? Do you think this PR is ready to merge? Unfortunately we're currently lacking support for Windows - that's why there's no CI tests for this platform 😢

[chrisglein]

Hi @chrisglein @jonthysell, thanks for the contribution! 🙏 Have you tested if those changes won't break the current behavior of native stack? Do you think this PR is ready to merge? Unfortunately we're currently lacking support for Windows - that's why there's no CI tests for this platform 😢

I've tested in two different Windows apps using a different combination of features, and I've discovered no regressions in their behavior. I think this is ready to merge.

[tboba]

Let's ship it then

[tboba]

Hi @chrisglein @jonthysell, there's a new version of react-native-screens: 3.26.0 which has this change included. Check it out! If you find something wrong related to the newest version (this change is still buggy or doesn't work for you) let us know 🎉