Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullWindowOverlay demo not working #1815

Closed
maianhvu opened this issue Jul 10, 2023 · 3 comments
Closed

FullWindowOverlay demo not working #1815

maianhvu opened this issue Jul 10, 2023 · 3 comments
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@maianhvu
Copy link

maianhvu commented Jul 10, 2023

Description

FullWindowOverlay component was supposed to put its children on top of everything else, but that's not the case when any modal component (RN's <Modal /> or React Navigation screen whose stack presentation mode is modal).

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-07-10.at.17.48.45.mp4

Steps to reproduce

  1. Create a fresh Expo project
  2. Copy code from Test1096.tsx and install necessary dependencies
  3. Expected elements in <FullWindowOverlay /> to be on top of modals, but instead it's obscured whenever a modal component is displayed

Snack or a link to a repository

https://snack.expo.dev/@maianhvu/fullwindowoverlay-not-working?platform=ios

Screens version

3.20.0

React Native version

0.71.8

Platforms

iOS

JavaScript runtime

None

Workflow

Expo managed workflow

Architecture

None

Build type

Debug mode

Device

iOS simulator

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Missing repro This issue need minimum repro scenario Repro provided A reproduction with a snack or repo is provided and removed Missing repro This issue need minimum repro scenario labels Jul 10, 2023
@kkafar
Copy link
Member

kkafar commented Aug 21, 2023

Hey, I've just played around with clean RN (no Expo) application and the FullWindowOverlay seems to be working fine, thus my first conclusion is that the react-native-screens is not directly responsible for this issue and it is Expo who is causing it.

I'll dig around, however it might be worth bringing this issue to attention of the Expo team.

@kkafar
Copy link
Member

kkafar commented Aug 21, 2023

Hey, I've just tested Test1096 on both managed & bare Expo workflows & it seems to be working fine. I've done the same with the code you provided in a snack:

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-21.at.14.57.27.mp4

Works fine. I'm closing the issue, because it is possible that the problem was resolved in most recent Expo SDK / screens version.

Let me know (tag me) if you still see the issue on most recent package version (if so, please provide me with valid reproduction).

@kkafar kkafar closed this as completed Aug 21, 2023
@maianhvu
Copy link
Author

Hey, I've just tested Test1096 on both managed & bare Expo workflows & it seems to be working fine. I've done the same with the code you provided in a snack:

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-21.at.14.57.27.mp4
Works fine. I'm closing the issue, because it is possible that the problem was resolved in most recent Expo SDK / screens version.

Let me know (tag me) if you still see the issue on most recent package version (if so, please provide me with valid reproduction).

Sorry for the late reply! Turns out it's a bug with Expo Go&emdash;the moment I ejected the app via npx expo run:ios and ran it as a standalone app, it works well just like in your screen cap.

Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

2 participants