Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #69

Closed
cbepxpa3ym opened this issue Nov 26, 2024 · 2 comments
Closed

PHP 8.4 #69

cbepxpa3ym opened this issue Nov 26, 2024 · 2 comments

Comments

@cbepxpa3ym
Copy link
Contributor

Implicitly nullable parameter types are now deprecated.

Examples:

Deprecated: Softonic\GraphQL\Client::query(): Implicitly marking parameter $variables as nullable is deprecated, the explicit nullable type must be used instead in \vendor\softonic\graphql-client\src\Client.php on line 31

Deprecated: Softonic\GraphQL\ResponseBuilder::__construct(): Implicitly marking parameter $dataObjectBuilder as nullable is deprecated, the explicit nullable type must be used instead in \vendor\softonic\graphql-client\src\ResponseBuilder.php on line 11

Please, fix this.

@joskfg
Copy link
Collaborator

joskfg commented Nov 26, 2024

Hi,

Thank you for bringing this to our attention. Currently, compatibility with PHP 8.4 has not yet been implemented. We plan to address this as soon as we have the necessary bandwidth.

In the meantime, if you'd like to expedite the process, we would greatly appreciate any contributions via a Pull Request. Your support would be invaluable.

Thank you for your understanding and for contributing to the project!

@joskfg
Copy link
Collaborator

joskfg commented Dec 9, 2024

Thanks for fixing it in #70

@joskfg joskfg closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants