Optimize Database#setup_attachment_class method #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Pick the top-most definition like | ||
| # Paperclip::AttachmentRegistry#definitions_for | ||
| names_for_ancestor = ancestor.attachment_definitions.keys rescue [] | ||
| if names_for_ancestor.member?(name) | ||
| if ancestor.attachment_definitions.member?(name) | ||
| @attachment_class = ancestor |
There was a problem hiding this comment.
Can't we break after first definition found? Why comment says that we are looking for top-most definition? How about class A defining attachment and class B < A overriding attachment definition? In this case I think we should get definitions from class B but this code will find definition from A.
|
@jarl-dk Could you review and eventually merge this pull? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16 "Speed regression for #attachment accessor (getter) between 2.2.2 and 2.3.1 version".