Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link_df() with diagnostics=True: works with pip trackpy, breaks with github trackpy #45

Open
charlesreid1 opened this issue Nov 10, 2017 · 0 comments

Comments

@charlesreid1
Copy link
Contributor

charlesreid1 commented Nov 10, 2017

I noticed several example notebooks (particularly, linking-diagnostics) using a legacy argument to link_df(), namely diagnostics = True. These notebooks import the regular link_df(), but the diagnostics = True keyword has recently been removed. This is not a problem when using the pip version of trackpy (where the diagnostics keyword is still there), but it breaks the examples when using the latest github version of trackpy.

I plan to fix this with existing pull request #44 but I wanted to suggest a "recommended" method for users to import the legacy version of link_df(), in case they do want diagnostics. Here's what I did:

import trackpy as tp
import trackpy.linking.legacy as tplegacy

...

t = tplegacy.link_df(f, 13, memory=3, diagnostics=True)
@charlesreid1 charlesreid1 changed the title Trackpy link_df diagnostics Trackpy link_df() with diagnostics=True: works with pip trackpy, breaks with github trackpy Nov 10, 2017
@charlesreid1 charlesreid1 changed the title Trackpy link_df() with diagnostics=True: works with pip trackpy, breaks with github trackpy link_df() with diagnostics=True: works with pip trackpy, breaks with github trackpy Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant