Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sofa.Util makes use of global isEqual function #3

Open
0x-r4bbit opened this issue Mar 18, 2014 · 1 comment
Open

sofa.Util makes use of global isEqual function #3

0x-r4bbit opened this issue Mar 18, 2014 · 1 comment

Comments

@0x-r4bbit
Copy link
Contributor

Maybe @cburgdorf know what's going on here?
Take a look here https://github.com/sofa/sofa-core/blob/master/src/sofa.util.js#L5 and here https://github.com/sofa/sofa-core/blob/master/src/sofa.util.js#L190

Wonder where it's coming from. We probably have to build such a function on sofa.Util ?

@cburgdorf
Copy link
Member

Oh, that's batshit crazy. The reason for that is that I ripped this code out of lodash and probably did it half assed. It's probably never called which is why we never ran into any issues yet. But yep, it screams for a fix ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants