You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR proposed to define base class functions as final and override these functions (which are templated) in child classes as a protected function. These changes are breaking but could be done in several steps:
If we do that, I recommend to use strong types in the functions accepting VecId. Indeed, today the VecId for a force is the same type than the VecId for a velocity, and it's a source of mistake when the function accepts both forces and velocities.
This issue is created further to #4943
This PR proposed to define base class functions as final and override these functions (which are templated) in child classes as a protected function. These changes are breaking but could be done in several steps:
doFunctionName()
+ compatibility layerThis project could have several benefits:
The text was updated successfully, but these errors were encountered: