Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #875 #884

Conversation

UtkarshShah0
Copy link
Contributor

What this PR does / why we need it:
In class Foxinsocks using http protocol can be insecure so replaced it with https

Which issue this PR fixes:
fixes #875

Special notes for your reviewer:
SODACODE 2022 thanks

In class Foxinsocks using http protocol can be insecure so replaced it with https protocol
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #884 (84064af) into master (795934f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
- Coverage   70.59%   70.57%   -0.03%     
==========================================
  Files         180      180              
  Lines       18825    18825              
  Branches     2769     2769              
==========================================
- Hits        13289    13285       -4     
- Misses       4694     4695       +1     
- Partials      842      845       +3     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-1.02%) ⬇️

@UtkarshShah0 UtkarshShah0 deleted the foxinsocks_http_protocol branch April 25, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In class Foxinsocks using http protocol can be insecure
1 participant