Fixed issue #874 #883
Closed
Fixed issue #874 #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In push_prometheus_alert function replaced http with https to make it more secure
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 70.59% 70.57% -0.03%
==========================================
Files 180 180
Lines 18825 18825
Branches 2769 2769
==========================================
- Hits 13289 13285 -4
- Misses 4694 4695 +1
- Partials 842 845 +3
|
joseph-v
reviewed
Apr 25, 2022
| @@ -51,7 +51,7 @@ def push_prometheus_alert(self, alerts): | |||
|
|
|||
| self.alerts.append(dict) | |||
| try: | |||
| response = requests.post('http://' + host + ":" + port + | |||
| response = requests.post('https://' + host + ":" + port + | |||
There was a problem hiding this comment.
Can you guide me how to solve this issue please.
There was a problem hiding this comment.
This requires adding Authentication/Authorization support for the services (This issue is not part of SODACODE)
There was a problem hiding this comment.
Thankyou, I got it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In push_prometheus_alert function replaced http with https to make it more secure
Which issue this PR fixes:
fixes #874
Special notes for your reviewer:
SODACODE 2022 thanks