Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static builder method documentation issue #55

Open
MarcinOrlowski opened this issue Apr 28, 2016 · 2 comments
Open

Static builder method documentation issue #55

MarcinOrlowski opened this issue Apr 28, 2016 · 2 comments

Comments

@MarcinOrlowski
Copy link

README.md says:

In your Activity you will use the generated Builder class (the name of your fragment with "Builder" suffix) instead of new MyFragment() or a static MyFragment.newInstance(int id, String title) method.

this is not true with 3.0.2. The correct form seem to be:

In your Activity you will use the generated Builder class (the name of your fragment with "Builder" suffix) instead of new MyFragment() or a static MyFragmentBuilder.newMyFragment(int id, String title) method.

@sockeqwe
Copy link
Owner

Hm, this is a misunderstanding. What I wanted to say is instead of the "traditional" way of instantiating an Fragment (like new MyFragment() or a static MyFragment.newInstance(...) which seems to be best practice) you can use the generated Builder from FragmentArgs

@MarcinOrlowski
Copy link
Author

MarcinOrlowski commented May 10, 2016

I was just flaging that there's high chance current documentation suggests something else you wanted to say and maybe rephrasing this portion of documentation or adding additional clarification would be beneficial for future users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants