Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udhcp.user unnecessary commits #442

Open
owendelong opened this issue May 30, 2022 · 0 comments · May be fixed by #785
Open

udhcp.user unnecessary commits #442

owendelong opened this issue May 30, 2022 · 0 comments · May be fixed by #785
Labels
bug good first issue scale22x

Comments

@owendelong
Copy link
Collaborator

owendelong commented May 30, 2022 •
edited by sarcasticadmin
Loading

Description

udhcp.user uci commits hostname whether or not it has changed.

Specifically this is currently happening:

scale-network/openwrt/files/etc/udhcpc.user

Lines 24 to 26 in 2d785b3

if [ ! -z "$hostname" ]; then
uci set 'system.@system[0].hostname'="$hostname"
uci commit

Acceptance Criteria

  • Test if old hostname and DHCP supplied hostnames are identical and don't uci commit if no change.
ruebenramirez added a commit to ruebenramirez/scale-network that referenced this issue Oct 8, 2024
@ruebenramirez
udhcp.user uci commit only new hostnames
5af17e4 
Instead of always committing a provided hostname, only commit new hostnames, where
the new hostname doesn't match the current hostname.

Resolves socallinuxexpo#442
@ruebenramirez ruebenramirez linked a pull request Oct 8, 2024 that will close this issue
Open
3 tasks
ruebenramirez added a commit to ruebenramirez/scale-network that referenced this issue Oct 10, 2024
@ruebenramirez
udhcp.user uci commit only new hostnames
9fd3c2a 
Instead of always committing a provided hostname, only commit new hostnames, where
the new hostname doesn't match the current hostname.

Resolves socallinuxexpo#442
ruebenramirez added a commit to ruebenramirez/scale-network that referenced this issue Oct 10, 2024
@ruebenramirez
udhcp.user uci commit only new hostnames
c4c2352 
Instead of always committing a provided hostname, only commit new hostnames, where
the new hostname doesn't match the current hostname.

Resolves socallinuxexpo#442
ruebenramirez added a commit to ruebenramirez/scale-network that referenced this issue Oct 10, 2024
@ruebenramirez
udhcp.user uci commit only new hostnames
2c9c42b 
Instead of always committing a provided hostname, only commit new hostnames, where
the new hostname doesn't match the current hostname.

Resolves socallinuxexpo#442
sarcasticadmin pushed a commit that referenced this issue Nov 4, 2024
@ruebenramirez @sarcasticadmin
udhcp.user uci commit only new hostnames
2eab0f5 
Instead of always committing a provided hostname, only commit new hostnames, where
the new hostname doesn't match the current hostname.

Resolves #442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue scale22x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] - udhcp.user uci commit only new hostnames ruebenramirez/scale-network
2 participants
@owendelong @sarcasticadmin