From fdc3e767220fb97dffd11315c0faf264a77058d6 Mon Sep 17 00:00:00 2001 From: Simon Torres Date: Thu, 24 Oct 2024 17:11:05 -0300 Subject: [PATCH 1/4] Handle the case when no filename is provided, create a clean exit --- goodman_photometry/utils.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/goodman_photometry/utils.py b/goodman_photometry/utils.py index 91535a9..90ba83a 100644 --- a/goodman_photometry/utils.py +++ b/goodman_photometry/utils.py @@ -102,6 +102,10 @@ def get_astrometry_args(arguments=None): print(__version__) sys.exit(0) + if not args.filename: + parser.print_help() + parser.exit(0, "\nPlease specify a filename to process.\n") + return args @@ -164,4 +168,8 @@ def get_photometry_args(arguments=None): print(__version__) sys.exit(0) + if not args.filename: + parser.print_help() + parser.exit(0, "\nPlease provide a filename to process.\n") + return args From 4f879a190d9b46730b5085e46934cf8dcc65b249 Mon Sep 17 00:00:00 2001 From: Simon Torres Date: Thu, 24 Oct 2024 17:11:48 -0300 Subject: [PATCH 2/4] add conda-forge channel and dependencies to environment.yml definition --- environment.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/environment.yml b/environment.yml index 2ba76b0..3d3775b 100644 --- a/environment.yml +++ b/environment.yml @@ -1,7 +1,10 @@ name: goodman_photometry channels: - defaults + - conda-forge dependencies: + - astromatic-source-extractor + - astromatic-scamp - pip - pip: - asciitree==0.3.3 From 7d3dbea51c86221e3388525ed2ed16e5c3c3f026 Mon Sep 17 00:00:00 2001 From: Simon Torres Date: Thu, 24 Oct 2024 17:12:58 -0300 Subject: [PATCH 3/4] Update project urls and add myself as maintainer --- pyproject.toml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 7e2534f..601f214 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -22,7 +22,8 @@ authors = [ {name = "Felipe Navarete", email = "felipe.navarete@noirlab.edu "}, ] maintainers = [ - {name = "Felipe Navarete", email = "felipe.navarete@noirlab.edu "} + {name = "Felipe Navarete", email = "felipe.navarete@noirlab.edu "}, + {name = "Simón Torres", email = "simon.torres@noirlab.edu "} ] classifiers = [ @@ -63,9 +64,9 @@ dependencies = [ ] [project.urls] -"Homepage" = "https://github.com/navarete/goodman_photometry" -"Bug Reports" = "https://github.com/navarete/goodman_photometry/issues" -"Source" = "https://github.com/navarete/goodman_photometry" +"Homepage" = "https://github.com/soar-telescope/goodman_photometry" +"Bug Reports" = "https://github.com/soar-telescope/goodman_photometry/issues" +"Source" = "https://github.com/soar-telescope/goodman_photometry" [project.scripts] redastrometry = "goodman_photometry.astrometry:goodman_astrometry" From c19246388aa9e51492c359e0abc447c057bddff0 Mon Sep 17 00:00:00 2001 From: Simon Torres Date: Thu, 24 Oct 2024 17:21:52 -0300 Subject: [PATCH 4/4] add badges --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index f3e2d17..aabaf9a 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,8 @@ # goodman_photometry + +[![Upload to PYPI](https://github.com/soar-telescope/goodman_photometry/actions/workflows/python-publish.yml/badge.svg)](https://github.com/soar-telescope/goodman_photometry/actions/workflows/python-publish.yml) +[![pypi](https://img.shields.io/pypi/v/goodman_photometry.svg?style=flat)](https://pypi.org/project/goodman-photometry/) + Routines to perform automatic astrometry and photometry of goodman imaging observations The codes were initially based on STDPipe (https://github.com/karpov-sv/stdpipe) and adapted for Goodman HST.