-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1552377: Add support for flatmap using udtf #2812
base: SNOW-1830033-dataframe-api-bcrs
Are you sure you want to change the base?
SNOW-1552377: Add support for flatmap using udtf #2812
Conversation
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on docstrings it seems unclear what the difference between map and flatmap is.
let me update the doc strings. The main difference is df.map is 1-1 mapping for each row and flat map can have 1-many mapping. |
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
…add-support-for-flatmap-using-udtf
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1552377
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds implementation for
Dataframe.flatmap
and refactors implementation ofDataframe.map
to de-duplicate common code used in flatmap.