Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1552377: Add support for flatmap using udtf #2812

Open
wants to merge 8 commits into
base: SNOW-1830033-dataframe-api-bcrs
Choose a base branch
from

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Dec 26, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1552377

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR adds implementation for Dataframe.flatmap and refactors implementation of Dataframe.map to de-duplicate common code used in flatmap.

Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review January 2, 2025 19:13
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners January 2, 2025 19:13
@sfc-gh-aalam sfc-gh-aalam requested review from sfc-gh-jdu, sfc-gh-yixie and sfc-gh-aling and removed request for a team January 2, 2025 19:13
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on docstrings it seems unclear what the difference between map and flatmap is.

@sfc-gh-aalam
Copy link
Contributor Author

Based on docstrings it seems unclear what the difference between map and flatmap is.

let me update the doc strings. The main difference is df.map is 1-1 mapping for each row and flat map can have 1-many mapping.

Copy link

github-actions bot commented Jan 3, 2025

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

github-actions bot commented Jan 3, 2025

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

github-actions bot commented Jan 3, 2025

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants