Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1842464 Fix the stored procedure build break #2703

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

sfc-gh-oplaton
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1842464

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Add explicit dependencies on python-dateutil to setup.py and recipe/meta.yaml.

@sfc-gh-aalam
Copy link
Contributor

we also need to fix setup.py: https://ci-dev-142.int.snowflakecomputing.com/job/RT-Precommit-Tests/71/console

that fix is probably different and needs investigation.

@sfc-gh-aalam
Copy link
Contributor

I'm restarting https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/1484/ since the failures could be due to branch name change

@sfc-gh-aalam
Copy link
Contributor

@sfc-gh-oplaton let's update changelog to say we are adding new dependency

Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update changelog too.

@sfc-gh-oplaton
Copy link
Contributor Author

@sfc-gh-oplaton let's update changelog to say we are adding new dependency

Done.

@sfc-gh-oplaton
Copy link
Contributor Author

let's update changelog too.

Done.

@sfc-gh-oplaton sfc-gh-oplaton merged commit 77ed9a3 into main Dec 3, 2024
39 checks passed
@sfc-gh-oplaton sfc-gh-oplaton deleted the oplaton/snow-1842464-sproc-daily-build-break branch December 3, 2024 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants