Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom minimum voting power score when voting on offchain proposals #597

Open
wa0x6e opened this issue Aug 7, 2024 · 0 comments · May be fixed by #614
Open

feat: support custom minimum voting power score when voting on offchain proposals #597

wa0x6e opened this issue Aug 7, 2024 · 0 comments · May be fixed by #614
Assignees

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Aug 7, 2024

Currently, we only check that the user's voting power is > 0 to allow voting on offchain spaces.

We should retrieve the minScore from the voteValidation property on offchain proposal, and set the minimum score for voting from it (onchain proposals will always have minScore = 0)

This score will be used in the votingPower composable/stores to determine whether a user can vote on a proposal, or create a space, and show the corresponding warning message

This feature will be based on #511 (extracted as the vote reason PR is heavy enough, and not restart the review process)

@wa0x6e wa0x6e self-assigned this Aug 7, 2024
@wa0x6e wa0x6e changed the title feat: support custom minimum voting power score on offchain proposal voting feat: support custom minimum voting power score when voting on offchain proposals Aug 7, 2024
@wa0x6e wa0x6e changed the title feat: support custom minimum voting power score when voting on offchain proposals feat: support custom minimum voting power score when proposing/voting on offchain proposals Aug 11, 2024
@wa0x6e wa0x6e linked a pull request Aug 11, 2024 that will close this issue
@wa0x6e wa0x6e changed the title feat: support custom minimum voting power score when proposing/voting on offchain proposals feat: support custom minimum voting power score when voting on offchain proposals Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant