Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider all delegation strategies #4938

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

ChaituVR
Copy link
Member

Summary

Related to https://github.com/snapshot-labs/workflow/issues/306

  • Previously we consider only first delegation strategy, this is resulting in wrong voting power in delegates page

How to test

  1. Go to https://snapshot.org/#/delegate/sandboxdao.eth
  2. you will see vp of first delegation strategy
  3. After the fix, you will see voting power of all delegation strategies

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/views/DelegateView.vue:175

  • Ensure that the new logic of summing up scores from all delegation strategies is covered by tests.
scores.forEach(delegationScore => {
@ChaituVR ChaituVR merged commit 93da516 into master Nov 26, 2024
7 checks passed
@ChaituVR ChaituVR deleted the fix-delegation-voting-power branch November 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants