Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown footnote anchors append to root url #4790

Open
HerrGertrud opened this issue Jun 23, 2024 · 2 comments
Open

Markdown footnote anchors append to root url #4790

HerrGertrud opened this issue Jun 23, 2024 · 2 comments
Labels
stale Issues that are old and soon to be closed

Comments

@HerrGertrud
Copy link

Proposal description supports markdown footnotes but the resulting anchors append to the snapshot root url instead of the open proposal which breaks their funcitonality and issues a warning "leaving page".

Example reproducer:

## Example
Text block with footnote[^1] continuing to footnote[^2].

[^1]: This is where the link should route for footnote 1
[^2]: This is where the link should route for footnote 2

--- 

### Second chapter
Lorem ipsum
- dolor
- sit
- amet
@HerrGertrud HerrGertrud changed the title Mardown footnote anchors append to root url Markdown footnote anchors append to root url Jun 23, 2024
@mktcode
Copy link
Contributor

mktcode commented Jul 18, 2024

I think the other problem is the Vue router using anchors for routes instead of the browser's history API.

Thoughts:

  • Extend the parser to generate custom (js based) scroll links.
  • Collapsed long proposal texts need to be expaneded when clicking on a footnote.
  • Use history API instead (which requires redirecting old links, which can only be done in the client)
  • Disable the syntax and make it clear that it is not supported or at least doesn't support linking to the footnotes.

Copy link

stale bot commented Nov 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that are old and soon to be closed label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that are old and soon to be closed
Projects
None yet
Development

No branches or pull requests

2 participants