Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SafeSnap] Value in batch JSON is not listed as integer #1916

Open
auryn-macmillan opened this issue Jan 31, 2022 · 2 comments
Open

[SafeSnap] Value in batch JSON is not listed as integer #1916

auryn-macmillan opened this issue Jan 31, 2022 · 2 comments
Labels
enhancement New feature or request plugin

Comments

@auryn-macmillan
Copy link
Contributor

Expected behavior

In the Batch Transaction JSON, value should be an integer representing the wei attached to the call.

Actual behavior

value lists a decimal number.
See this proposal for an example: https://snapshot.org/#/gnosis.eth/proposal/0x9b12a093e17e92b56d070ed876883d8c2331678ca3945e44f66dd416cfd47a64

The following is the json for the first batch. Notice the value is 0.0, rather than 0.

[
	{
		"to": "0x3E70e80BDCD09eEA9680426C18D0590E3366a9e7",
		"operation": "0",
		"value": "0.0",
		"data": "0xb3d50787000000000000000000000000ca771eda0c70aa7d053ab1b25004559b918fe6620000000000000000000000000000000000000000000000000000000000000060000000000000000000000000a6b71e26c5e0845f74c812102ca7114b6a896ab200000000000000000000000000000000000000000000000000000000000002841688f0b9000000000000000000000000d9db270c1b5e3bd161e8c8503c55ceabee7095520000000000000000000000000000000000000000000000000000000000000060eca46d74b690b643257ba37cab7348c236bddbad705c4f6ec5ab0afc1b38d32600000000000000000000000000000000000000000000000000000000000001e4b63e800d00000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000003000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001c0000000000000000000000000f48f2b2d2a534e402487b3ee7c18c33aec0fe5e4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000500000000000000000000000004ce1ccf81ae660e23ca0c0823911df709b0e7fc0000000000000000000000000a2aaa50135da1628c8d29216f25bf2a28efb21900000000000000000000000054b8b7ddf8453de6d53a59e91877a5ad1a01b5b80000000000000000000000005efd3e2e18696a44a4cb3f3ea5f637c3f3cccf0f000000000000000000000000f10fe968d1856131fc6835ed7d7126eaf8b5a6b600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
	},
	{
		"to": "0x3E70e80BDCD09eEA9680426C18D0590E3366a9e7",
		"operation": "0",
		"value": "0.0",
		"data": "0xb3d50787000000000000000000000000ca07eaa4253638d286cad71cbceec11803f2709a0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000a6b71e26c5e0845f74c812102ca7114b6a896ab200000000000000000000000000000000000000000000000000000000000002441688f0b9000000000000000000000000d9db270c1b5e3bd161e8c8503c55ceabee70955200000000000000000000000000000000000000000000000000000000000000606ce19f93047483e9adbbb34c400709c4374377c5d1c965fe414e00d0262df89b00000000000000000000000000000000000000000000000000000000000001a4b63e800d0000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000180000000000000000000000000f48f2b2d2a534e402487b3ee7c18c33aec0fe5e400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000030000000000000000000000002caef7f0ee82fb0abf1ab0dcd3a093803002e705000000000000000000000000762a821270e6a1afa44327bda381a91542c53317000000000000000000000000d364d2902b46186516cba58c3d4b93e437eea1fb00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
	},
	{
		"to": "0x3E70e80BDCD09eEA9680426C18D0590E3366a9e7",
		"operation": "0",
		"value": "0.0",
		"data": "0xb3d50787000000000000000000000000a1cb7762f40318ee0260f53e15de835ff001cb7e0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000a6b71e26c5e0845f74c812102ca7114b6a896ab200000000000000000000000000000000000000000000000000000000000002041688f0b9000000000000000000000000d9db270c1b5e3bd161e8c8503c55ceabee709552000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000164b63e800d0000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000f48f2b2d2a534e402487b3ee7c18c33aec0fe5e40000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000ca771eda0c70aa7d053ab1b25004559b918fe66200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
	}
]

cc @carlosfebres

@bonustrack bonustrack transferred this issue from snapshot-labs/snapshot-plugins Mar 9, 2022
@bonustrack bonustrack reopened this Mar 9, 2022
@bonustrack bonustrack reopened this Mar 9, 2022
@stale
Copy link

stale bot commented Jun 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 13, 2022
@samuveth samuveth added this to the Execution as core feature milestone Jun 14, 2022
@stale stale bot removed the wontfix This will not be worked on label Jun 14, 2022
@samuveth samuveth added the enhancement New feature or request label Jun 14, 2022
@mktcode mktcode self-assigned this Aug 2, 2022
@zzuziak
Copy link
Contributor

zzuziak commented Feb 7, 2023

@samuveth @mktcode what's the status of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants