Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Typescript Coverage #271

Open
midgerate opened this issue Feb 23, 2022 · 2 comments · May be fixed by #572
Open

Better Typescript Coverage #271

midgerate opened this issue Feb 23, 2022 · 2 comments · May be fixed by #572
Assignees
@wa0x6e @bigint
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@midgerate
Copy link
Contributor

Hub has very less ts coverage making it very prone to bugs that can be caused when doing changes.

Start off by changing noImplicitAny: true in tsconfig and work your way to adding types to all the files in the codebase.
@midgerate midgerate added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 23, 2022
@bigint
Copy link

bigint commented Feb 23, 2022

I'll try some here 🤞🏻

@baby636 baby636 mentioned this issue Nov 5, 2022
Open
@baby636 baby636 mentioned this issue Dec 25, 2022
Open
@zzuziak
Copy link
Contributor

zzuziak commented Feb 8, 2023

@ChaituVR would you be up for listing all improvements needed? We can separate into individual features and create a milestone for it 🤔

@wa0x6e wa0x6e self-assigned this Apr 14, 2023
@wa0x6e wa0x6e linked a pull request Apr 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wa0x6e wa0x6e

@bigint bigint

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve typescript coverage snapshot-labs/snapshot-hub
4 participants
@wa0x6e @zzuziak @bigint @midgerate