Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing in consecutive braces in f-string #223

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

mbhall88
Copy link
Member

This PR closes #222

I also took the opportunity to update the min. black version to v24.3.0 which contains a security vulnerability fix. In the process I realised that the process of finding the project root directory changed in black v24.2 and we were using their function for doing this. Essentially they now ignore a pyproject.toml file if it doesn't contain [tool.black], which makes a bunch of tests fail and isn't quite the behaviour we want. So I have essentially just copied their function from v24.1.0 and pasted it into our code.

Copy link
Collaborator

@bricoletc bricoletc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, if only they were as easy to fix!
Thanks @mbhall88

@mbhall88 mbhall88 merged commit 0f20494 into snakemake:master Apr 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious additional space added between adjacent replacement fields
2 participants