Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WWW, CLI: hide EID and show the secondary ID via configurable title #17

Closed
tampakrap opened this issue Sep 13, 2016 · 5 comments
Closed

Comments

@tampakrap
Copy link
Contributor

Under the user profile a user can see his EID, but this information is useless and confusing. Instead, it would be good to show up the sec_id, via a configurable name, synced from a configurable LDAP attribute (which could be for example the employee's company LDAP ID).

https://metacpan.org/pod/App::Dochazka::REST::Guide#Employee

@smithfarm smithfarm changed the title hide EID and show the secondary ID via configurable title WWW, CLI: hide EID and show the secondary ID via configurable title Sep 13, 2016
@smithfarm
Copy link
Owner

I disagree that it's useless. If an organization had no other unique numeric ID for its employees, it could use Dochazka EID. In that case, HR would tell employees about their EID and nobody would be confused :-)

But otherwise I agree that if there is a unique numeric ID coming from LDAP, it can be used in place of EID.

One other nitpick: in Dochazka terminology users are referred to as "employees".

@tampakrap
Copy link
Contributor Author

agreed, so options are: don't expose it when sec_id is set up, or make it configurable if it will be exposed

@smithfarm
Copy link
Owner

For WWW I don't have a good way to make the name configurable right now, but the LDAP attribute is configurable and in the next release of WWW the employee profile will say "Workforce ID" instead of EID.

Next I will do CLI.

smithfarm added a commit to smithfarm/dochazka-cli that referenced this issue Sep 15, 2016
...and present sec_id as Workforce ID.

Fixes: smithfarm/dochazka#17
Signed-off-by: Nathan Cutler <[email protected]>
@smithfarm
Copy link
Owner

WWW: fixed by smithfarm/dochazka-www@9e83d5a
CLI: fixed by smithfarm/dochazka-cli@a22e01c

@smithfarm
Copy link
Owner

Opened smithfarm/mfile-www#11 to track the issue of passing config parameters to the JS side from a derived distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants