Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for Any API Large and Multi-word responses #78

Open
mhpaler opened this issue Feb 4, 2022 · 5 comments
Open

Add examples for Any API Large and Multi-word responses #78

mhpaler opened this issue Feb 4, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@mhpaler
Copy link

mhpaler commented Feb 4, 2022

In addition to the standard GET request for Chainlink Connect to any API, Chainlink also supports multi-variable and large (bytes or string > 32bytes) responses.

On first glance it appears that executing these examples in hardhat-starter-kit will require a adjustment to, or the addition of a second MockOracle.

@andrejrakic
Copy link
Contributor

Excellent idea, @mpaler. Thanks for raising this issue!

@mhpaler
Copy link
Author

mhpaler commented Feb 4, 2022

Taking a crack at it now...

Appears to be an issue over in core Chainlink too? not finding any test examples over there (yet) that we can pull from...

There is this smartcontractkit/chainlink#5639 which seems related as i believe we'll need to create an Operator mock, vs. the current Oracle mock.

@kevin3010
Copy link

Will this work ?

Action Steps

  • Add fulfillOracleRequest2 method (supports multi-word and large responses) in existing MockOracle.sol
  • Create Multi-word API Consumer Contract
  • Create Tests for Multi-word API Consumer Contract

@andrejrakic
Copy link
Contributor

Hey @kevin3010, that sounds like a great plan. If you are going to open a PR, feel free to use examples from the official documentation as inspiration. Looking forward to it!

@andrejrakic andrejrakic added the enhancement New feature or request label Aug 25, 2022
@kevin3010
Copy link

ok I'll work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants